Clarify usage of beforematch event #11151
Conversation
This PR improves a paragraph which talks about firing the beforematch event by making it reference the revealing algorithm which actually fires it. It also sets the bubbles attribute to true, which wasn't specified before. Fixes whatwg#11150
There was a problem hiding this comment.
LGTM with nit.
This is a normative change (because of the new bubbling behavior) so it would be good to fill out the template completely before merging. Hopefully it will be simple to get approval from @jnjaeschke that Mozilla supports this behavior as well.
| data-x="event-beforematch">beforematch</code> at <var>currentNode</var>.</p></li> | ||
| data-x="event-beforematch">beforematch</code> with the <code | ||
| data-x="dom-Event-bubbles">bubbles</code> attribute initialized to true at | ||
| <var>currentNode</var>.</p></li> |
There was a problem hiding this comment.
Nit: the order should be "Fire an event named e at target with..." per https://dom.spec.whatwg.org/#firing-events
There was a problem hiding this comment.
Looking at the order of operations here, I guess we have a test that asserts the hidden attribute is still present?
If the event listener removes the attribute I guess the next step is a no-op, though the way it's worded makes that a bit unclear.
There was a problem hiding this comment.
Nit: the order should be "Fire an event named e at target with..." per https://dom.spec.whatwg.org/#firing-events
Done
If the event listener removes the attribute I guess the next step is a no-op, though the way it's worded makes that a bit unclear.
Do you have any suggestions to change the wording?
There was a problem hiding this comment.
If we referenced an actual "remove an attribute" primitive (assuming there is one) it would probably be clearer, but it doesn't have to be fixed for this PR.
|
This is not editorial, and the relevant API is part of interop-25. I didn't immediately find a test checking that hidden attribute is still present, but maybe it is checked in some other test? |
Ok, I removed the sentence about editorialness from the commit message.
I didn't find any tests, so I will add one |
|
I updated the OP, just need implementer interest |
|
@jnjaeschke, since you brought this up, can you speak for Mozilla's support for |
|
I was on pto and missed the pings, sorry! |
The hidden attribute is supposed to be removed after the beforematch event, but this wasn't tested in WPTs. This patch adds coverage for this. More context: whatwg/html#11151 Change-Id: Ib64a06de356f34d2ea062a6a377b6c1189fb3f63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6388419 Reviewed-by: Vladimir Levin <[email protected]> Commit-Queue: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1442847}
The hidden attribute is supposed to be removed after the beforematch event, but this wasn't tested in WPTs. This patch adds coverage for this. More context: whatwg/html#11151 Change-Id: Ib64a06de356f34d2ea062a6a377b6c1189fb3f63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6388419 Reviewed-by: Vladimir Levin <[email protected]> Commit-Queue: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1442847}
The hidden attribute is supposed to be removed after the beforematch event, but this wasn't tested in WPTs. This patch adds coverage for this. More context: whatwg/html#11151 Change-Id: Ib64a06de356f34d2ea062a6a377b6c1189fb3f63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6388419 Reviewed-by: Vladimir Levin <[email protected]> Commit-Queue: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1442847}
…T, a=testonly Automatic update from web-platform-tests Check hidden attribute in beforematch WPT The hidden attribute is supposed to be removed after the beforematch event, but this wasn't tested in WPTs. This patch adds coverage for this. More context: whatwg/html#11151 Change-Id: Ib64a06de356f34d2ea062a6a377b6c1189fb3f63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6388419 Reviewed-by: Vladimir Levin <[email protected]> Commit-Queue: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1442847} -- wpt-commits: 8726dfcf3d1e74520dc2c5f2af8c9275e31e3bcb wpt-pr: 51866
…T, a=testonly Automatic update from web-platform-tests Check hidden attribute in beforematch WPT The hidden attribute is supposed to be removed after the beforematch event, but this wasn't tested in WPTs. This patch adds coverage for this. More context: whatwg/html#11151 Change-Id: Ib64a06de356f34d2ea062a6a377b6c1189fb3f63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6388419 Reviewed-by: Vladimir Levin <[email protected]> Commit-Queue: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1442847} -- wpt-commits: 8726dfcf3d1e74520dc2c5f2af8c9275e31e3bcb wpt-pr: 51866
…T, a=testonly Automatic update from web-platform-tests Check hidden attribute in beforematch WPT The hidden attribute is supposed to be removed after the beforematch event, but this wasn't tested in WPTs. This patch adds coverage for this. More context: whatwg/html#11151 Change-Id: Ib64a06de356f34d2ea062a6a377b6c1189fb3f63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6388419 Reviewed-by: Vladimir Levin <[email protected]> Commit-Queue: Joey Arhar <[email protected]> Cr-Commit-Position: refs/heads/main@{#1442847} -- wpt-commits: 8726dfcf3d1e74520dc2c5f2af8c9275e31e3bcb wpt-pr: 51866
…T, a=testonly Automatic update from web-platform-tests Check hidden attribute in beforematch WPT The hidden attribute is supposed to be removed after the beforematch event, but this wasn't tested in WPTs. This patch adds coverage for this. More context: whatwg/html#11151 Change-Id: Ib64a06de356f34d2ea062a6a377b6c1189fb3f63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6388419 Reviewed-by: Vladimir Levin <vmpstrchromium.org> Commit-Queue: Joey Arhar <jarharchromium.org> Cr-Commit-Position: refs/heads/main{#1442847} -- wpt-commits: 8726dfcf3d1e74520dc2c5f2af8c9275e31e3bcb wpt-pr: 51866 UltraBlame original commit: 147b0632ab6c26cf37244e55d9e8da7d2e139b92
…T, a=testonly Automatic update from web-platform-tests Check hidden attribute in beforematch WPT The hidden attribute is supposed to be removed after the beforematch event, but this wasn't tested in WPTs. This patch adds coverage for this. More context: whatwg/html#11151 Change-Id: Ib64a06de356f34d2ea062a6a377b6c1189fb3f63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6388419 Reviewed-by: Vladimir Levin <vmpstrchromium.org> Commit-Queue: Joey Arhar <jarharchromium.org> Cr-Commit-Position: refs/heads/main{#1442847} -- wpt-commits: 8726dfcf3d1e74520dc2c5f2af8c9275e31e3bcb wpt-pr: 51866 UltraBlame original commit: 147b0632ab6c26cf37244e55d9e8da7d2e139b92
…T, a=testonly Automatic update from web-platform-tests Check hidden attribute in beforematch WPT The hidden attribute is supposed to be removed after the beforematch event, but this wasn't tested in WPTs. This patch adds coverage for this. More context: whatwg/html#11151 Change-Id: Ib64a06de356f34d2ea062a6a377b6c1189fb3f63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6388419 Reviewed-by: Vladimir Levin <vmpstrchromium.org> Commit-Queue: Joey Arhar <jarharchromium.org> Cr-Commit-Position: refs/heads/main{#1442847} -- wpt-commits: 8726dfcf3d1e74520dc2c5f2af8c9275e31e3bcb wpt-pr: 51866 UltraBlame original commit: 147b0632ab6c26cf37244e55d9e8da7d2e139b92
This PR improves a paragraph which talks about firing the beforematch event by making it reference the revealing algorithm which actually fires it. It also sets the bubbles attribute to true, which wasn't specified before.
Fixes #11150
(See WHATWG Working Mode: Changes for more details.)
/interaction.html ( diff )